Fix missing update notification in tools view#70
Merged
Conversation
Introduces separate favicon and manifest files for light and dark modes, updating the layout to use media queries for color scheme detection. Refactors image organization, updates README references, and removes redundant code in web.rb. Bumps version to v2.5.2.
Add media=(prefers-color-scheme) attributes to favicon links so browsers pick light/dark icon variants; update dark and light favicon image assets (PNG, ICO, SVG) and remove the old generic /images/favicon.ico. The dark favicon SVG had its solid background rect removed (making it transparent), and layout.erb was adjusted to reference the themed icons. These changes enable proper favicons for light/dark modes and refresh the icon files.
Use the server-side ui_mode (Service::Helpers.env_variables[:ui_mode]) to choose theme stylesheet and favicons instead of relying on client prefers-color-scheme. Adds conditional includes for light/dark CSS and corresponding favicon/apple-touch/manifest assets, removes the previous media-based fallbacks, and adds a small comment for theme stylesheets. This ensures the served assets match the configured UI mode consistently.
Replace several dark-theme favicon assets (android-chrome 192/512, apple-touch-icon, favicon 16/32, .ico, and .svg) with updated versions. In favicon-dark.svg a background <rect> (48x48, rx/ry=2) was added to provide a consistent rounded background and improve visibility in the dark theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved theme support for the application's UI, specifically by adding separate light and dark mode favicon and manifest assets, and updating the layout to dynamically select the correct assets based on the UI mode. Additionally, it cleans up and simplifies the code that sets update notification variables in the web framework, and updates documentation for clarity. The application version is also incremented.
Theme support and asset management:
views/layout.erbto dynamically select light or dark mode favicon and manifest assets based on the current UI mode, including separate icons and manifest files for each theme.public/images/light/site.webmanifestandpublic/images/dark/site.webmanifest. [1] [2]site.webmanifestfile in favor of theme-specific manifests.README.mdto use the light mode logo asset.Web framework improvements:
framework/web.rbto set update notification variables (@recent_tag,@update_available) in abeforefilter instead of repeating code in every route, simplifying route handlers. [1] [2] [3] [4]Documentation:
README.mdfor clarity and added additional context on environment variables.Version bump:
v2.5.1tov2.5.2.